Add log_helpers.hpp with pure log-formatting functions#235
Merged
Conversation
- Update C++ test counts after the b9637 bump: total 417->440, test_server 179->188, test_jni_helpers 36->41 - Add a test_log_helpers.cpp row (13 tests) and a log_helpers.hpp subsection to the Native Helper Architecture section - Fix stale GIT_TAG b8953->b9637 and drop the dead branch note https://claude.ai/code/session_01Mmq9AfxTafNgQyt2c8tiLc
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_helpers.hppwith two pure log-formatting functions:log_level_nameandformat_log_as_jsontest_log_helpers.cpp) with 13 tests covering all functionsTest plan
src/test/cpp/test_log_helpers.cppcoveringlog_level_nameandformat_log_as_jsonRelated issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdhttps://claude.ai/code/session_01Mmq9AfxTafNgQyt2c8tiLc